Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test for issue 6915: features and transitive dev deps #12907

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

dtolnay
Copy link
Member

@dtolnay dtolnay commented Nov 1, 2023

Closes #6915.

That issue was fixed without realizing by #10103. In search of test coverage, I looked through rg '[a-z0-9_-]+ = \["[a-z0-9_-]+/[a-z0-9_-]+"\]' tests/testsuite/ and did not find any existing test that exercises this situation. The tests added by #10103 are focused on cycles and cargo tree, which is substantially different from #6915.

Tested by cargo test --test testsuite -- features::activating_feature_does_not_activate_transitive_dev_dependency.

@rustbot
Copy link
Collaborator

rustbot commented Nov 1, 2023

r? @epage

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 1, 2023
@epage
Copy link
Contributor

epage commented Nov 1, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Nov 1, 2023

📌 Commit 649a14d has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2023
@bors
Copy link
Contributor

bors commented Nov 1, 2023

⌛ Testing commit 649a14d with merge 5613aac...

@bors
Copy link
Contributor

bors commented Nov 1, 2023

☀️ Test successful - checks-actions
Approved by: epage
Pushing 5613aac to master...

@bors bors merged commit 5613aac into rust-lang:master Nov 1, 2023
19 checks passed
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 4, 2023
Update cargo

8 commits in b4d18d4bd3db6d872892f6c87c51a02999b80802..65e297d1ec0dee1a74800efe600b8dc163bcf5db
2023-10-31 18:19:10 +0000 to 2023-11-03 20:56:31 +0000
- fix(cli): Clarify --test is for targets, not test functions (rust-lang/cargo#12915)
- Updating "features" documentation to add a note about the new limit on number of features (rust-lang/cargo#12913)
- fix: merge `trim-paths` from different profiles (rust-lang/cargo#12908)
- Add regression test for issue 6915: features and transitive dev deps (rust-lang/cargo#12907)
- chore(deps): update rust crate gix to 0.55.2 (rust-lang/cargo#12906)
- chore(deps): update compatible (rust-lang/cargo#12905)
- docs(ref): Fix open-semver-range issue link (rust-lang/cargo#12904)
- docs(ref): Highlight commands to answer dep resolution questions (rust-lang/cargo#12903)

r? ghost
@ehuss ehuss added this to the 1.75.0 milestone Nov 6, 2023
@dtolnay dtolnay deleted the featuredevtest branch November 20, 2023 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature that affects dev dependencies can't be enabled
5 participants