Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Clean up package metadata #12352

Merged
merged 7 commits into from
Jul 17, 2023
Merged

refactor: Clean up package metadata #12352

merged 7 commits into from
Jul 17, 2023

Conversation

epage
Copy link
Contributor

@epage epage commented Jul 12, 2023

What does this PR try to resolve?

Clean up workspace metadata

  • Reduce noise by allowing fields to be inferred
    • I left documentation because that is runtime inferred on crates.io which has trade offs
  • Default package fields at the workspace level

Align us on a single edition

How should we test and review this PR?

Mostly relying on CI for this

Additional information

I noticed this and decided to do this while I was considering the idea of setting an MSRV to "latest" by leveraging #12341 and whether that should just be for cargo or for all workspace members. I'm leaning towards all workspace members as that is the only thing we test though strictly speaking people might be able to use lower versions; we just wouldn't officially support it.

@rustbot
Copy link
Collaborator

rustbot commented Jul 12, 2023

r? @weihanglo

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-cfg-expr Area: Platform cfg expressions A-cli-help Area: built-in command-line help A-dependency-resolution Area: dependency resolution and the resolver A-environment-variables Area: environment variables A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. A-interacts-with-crates.io Area: interaction with registries A-registry-authentication Area: registry authentication and authorization (authn authz) A-semver Area: semver specifications, version matching, etc. A-testing-cargo-itself Area: cargo's tests S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 12, 2023
@weihanglo
Copy link
Member

Thanks for this!

@bors r+

@bors
Copy link
Contributor

bors commented Jul 12, 2023

📌 Commit 7a12220 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 12, 2023
@bors
Copy link
Contributor

bors commented Jul 12, 2023

⌛ Testing commit 7a12220 with merge adc5551...

bors added a commit that referenced this pull request Jul 12, 2023
refactor: Clean up package metadata

### What does this PR try to resolve?

Clean up workspace metadata
- Reduce noise by allowing fields to be inferred
  - I left documentation because that is runtime inferred on crates.io which has trade offs
- Default package fields at the workspace level

Align us on a single edition

### How should we test and review this PR?

Mostly relying on CI for this

### Additional information

I noticed this and decided to do this while I was considering the idea of setting an MSRV to "latest" by leveraging #12341 and whether that should just be for `cargo` or for all workspace members.  I'm leaning towards all workspace members as that is the only thing we test though strictly speaking people might be able to use lower versions; we just wouldn't officially support it.
@weihanglo
Copy link
Member

@bors r-

version bump check is failing

@bors bors added S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 12, 2023
@bors
Copy link
Contributor

bors commented Jul 12, 2023

☀️ Try build successful - checks-actions
Build commit: adc5551 (adc555193f9f1e74a5634b6127f0dc2ed9562486)

@epage epage force-pushed the meta branch 3 times, most recently from ded239d to 210c817 Compare July 14, 2023 20:58
@bors
Copy link
Contributor

bors commented Jul 15, 2023

☔ The latest upstream changes (presumably #12361) made this pull request unmergeable. Please resolve the merge conflicts.

@epage
Copy link
Contributor Author

epage commented Jul 17, 2023

@weihanglo this looks ready if we merge it now and don't sneeze to break it again...

@weihanglo
Copy link
Member

Nice! Thank you.

@bors r+

@bors
Copy link
Contributor

bors commented Jul 17, 2023

📌 Commit 83a5859 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: The marked PR is awaiting some action (such as code changes) from the PR author. labels Jul 17, 2023
@bors
Copy link
Contributor

bors commented Jul 17, 2023

⌛ Testing commit 83a5859 with merge e1e2f2d...

@bors
Copy link
Contributor

bors commented Jul 17, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing e1e2f2d to master...

@bors bors merged commit e1e2f2d into rust-lang:master Jul 17, 2023
@epage epage deleted the meta branch July 18, 2023 20:12
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 18, 2023
Update cargo

11 commits in 694a579566a9a1482b20aff8a68f0e4edd99bd28..1b15556767f4b78a64e868eedf4073c423f02b93
2023-07-11 22:28:29 +0000 to 2023-07-18 14:44:47 +0000
- Fix "cargo doc --open" crash on WSL2 (rust-lang/cargo#12373)
- fix(git): respect scp-like URL for nested submodules (rust-lang/cargo#12359)
- Upgrade to indexmap v2 (rust-lang/cargo#12368)
- refactor: Clean up package metadata (rust-lang/cargo#12352)
- Correct unspecifiead to unspecified (rust-lang/cargo#12363)
- Replace invalid `panic_unwind` std feature with `panic-unwind` (rust-lang/cargo#12364)
- Bump to 0.74.0; update changelog (rust-lang/cargo#12361)
- Bump version of crates-io due to unintentional semver-breaking change (rust-lang/cargo#12357)
- chore: Automatically update dependencies monthly (rust-lang/cargo#12341)
- docs: Use heading attributes to control the fragment. (rust-lang/cargo#12339)
- Rustfmt with latest nightly. (rust-lang/cargo#12351)

r? ghost
@ehuss ehuss added this to the 1.73.0 milestone Jul 30, 2023
bors added a commit that referenced this pull request Dec 18, 2023
refactor: clean up package metadata

Like #12352 but for `homepage` and `repository`.

Inspired by <#13178 (comment)>.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-cfg-expr Area: Platform cfg expressions A-cli-help Area: built-in command-line help A-dependency-resolution Area: dependency resolution and the resolver A-environment-variables Area: environment variables A-infrastructure Area: infrastructure around the cargo repo, ci, releases, etc. A-interacts-with-crates.io Area: interaction with registries A-registry-authentication Area: registry authentication and authorization (authn authz) A-semver Area: semver specifications, version matching, etc. A-testing-cargo-itself Area: cargo's tests S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants