-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for descriptions on third-party subcommands in cargo --list
#10663
Conversation
r? @ehuss (rust-highfive has picked a reviewer for you, use r? to override) |
☔ The latest upstream changes (presumably #10804) made this pull request unmergeable. Please resolve the merge conflicts. |
|
macro_rules! description { | ||
($description:expr) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to self: maybe cargo_subcommand_metadata::description!();
with no string argument could embed env!(CARGO_PKG_DESCRIPTION)
by default.
☔ The latest upstream changes (presumably #11029) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably #11159) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably #11369) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably #11807) made this pull request unmergeable. Please resolve the merge conflicts. |
I'm sorry for not responding sooner. I'm going to close since nobody on the team has the capacity to help with this at this time. I've followed up on #10662 with some thoughts we had on the design. I think there might be some more discussion needed on the design, but I don't think any of us can follow up with it right now. Hopefully at some time in the future we can engage with this idea more. |
What does this PR try to resolve?
This PR implements my proposal in #10662 to enable
cargo --list
to show descriptions of third-party subcommands, not only the subcommands which are built into Cargo.How should we test and review this PR?
I have included an ELF note containing a description in the most recent version of the
cargo-expand
crate. You can confirm thatcargo --list
is able to print a description for that subcommand (on Linux only, to begin with).