Add crate type flag to rustc command #10093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @ehuss (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
/hold
|
Rustin170506
changed the title
Rustin170506
force-pushed
the
rustin-patch-rustc
branch
from
eb171b1 to
d66c2db
Compare
|
/unhold Ready for review! Also, I did some manual testing. ➜ hyper git:(master) ../cargo/target/debug/cargo rustc --crate-type lib,cdylib -Z unstable-options
Compiling pin-project-lite v0.2.7
Compiling bytes v1.1.0
Compiling cfg-if v1.0.0
Compiling itoa v0.4.8
Compiling fnv v1.0.7
Compiling lazy_static v1.4.0
Compiling try-lock v0.2.3
Compiling pin-utils v0.1.0
Compiling httpdate v1.0.2
Compiling tower-service v0.3.1
Compiling proc-macro2 v1.0.32
Compiling syn v1.0.81
Compiling libc v0.2.107
Compiling futures-core v0.3.17
Compiling log v0.4.14
Compiling futures-task v0.3.17
Compiling memchr v2.4.1
Compiling httparse v1.5.1
Compiling futures-channel v0.3.17
Compiling tokio v1.14.0
Compiling futures-util v0.3.17
Compiling tracing-core v0.1.21
Compiling want v0.3.0
Compiling http v0.2.5
Compiling quote v1.0.10
Compiling num_cpus v1.13.0
Compiling http-body v0.4.4
Compiling tokio-macros v1.6.0
Compiling tracing-attributes v0.1.18
Compiling tracing v0.1.29
Compiling hyper v0.14.15 (/Users/rustin/ClionProjects/hyper)
Finished dev [unoptimized + debuginfo] target(s) in 14.57s
➜ hyper git:(master) ll ./target/debug
total 3408
drwxr-xr-x 57 rustin staff 1.8K Nov 19 00:02 build
drwxr-xr-x 484 rustin staff 15K Nov 19 00:02 deps
drwxr-xr-x 2 rustin staff 64B Nov 17 20:40 examples
drwxr-xr-x 5 rustin staff 160B Nov 19 00:02 incremental
-rw-r--r-- 1 rustin staff 1.2K Nov 17 20:40 libhyper.d
-rwxr-xr-x 2 rustin staff 51K Nov 19 00:02 libhyper.dylib
-rw-r--r-- 2 rustin staff 1.6M Nov 19 00:02 libhyper.rlib |
Rustin170506
changed the title
Rustin170506
force-pushed
the
rustin-patch-rustc
branch
3 times, most recently
from
9be5b37 to
51f124f
Compare
Signed-off-by: hi-rustin <[email protected]>
Rustin170506
force-pushed
the
rustin-patch-rustc
branch
from
e890be1 to
3231e31
Compare
ehuss
reviewed
Nov 22, 2021
There was a problem hiding this comment.
This looks great, thanks for moving this forward!
Can you remove the close line from the PR description? We normally don't close tracking issues until after it is stabilized. Additionally, it is customary to provide a description of what the PR does besides just pointing to an issue.
Signed-off-by: hi-rustin <[email protected]>
Rustin170506
force-pushed
the
rustin-patch-rustc
branch
from
3231e31 to
660ce6b
Compare
Signed-off-by: hi-rustin <[email protected]>
|
@ehuss All comments addressed! Could you please take a look again? Thanks! 💚 💙 💜 💛 ❤️ |
|
Thanks! @bors r+ |
|
📌 Commit 137f9bc has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 30, 2021
Update cargo 6 commits in 7f08ace4f1305de7f3b1b0e2f765911957226bd4..294967c53f0c70d598fc54ca189313c86c576ea7 2021-11-24 17:54:39 +0000 to 2021-11-29 19:04:22 +0000 - Fix some tests with output collisions. (rust-lang/cargo#10137) - Description of the targets that can be applied (rust-lang/cargo#10109) - Improve unused patch message when source URLs mismatched (rust-lang/cargo#10130) - Add a note about doctest xcompile. (rust-lang/cargo#10132) - book: add edit links to specific pages (rust-lang/cargo#10124) - Add crate type flag to rustc command (rust-lang/cargo#10093)
This was referenced Feb 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #10083