Skip to content

Commit

Permalink
Auto merge of rust-lang#79074 - Mark-Simulacrum:fix-ci-llvm, r=jyn514
Browse files Browse the repository at this point in the history
Install CI llvm into the library directory

In other words, my concern in rust-lang#78932 (comment) was perfectly justified by something we were already doing. For now just special case CI LLVM, but in the future we may want a more general fix.

Fixes rust-lang#79071.

r? `@alexcrichton`
  • Loading branch information
bors committed Nov 16, 2020
2 parents 603ab5b + 4feaa35 commit f4d014c
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/bootstrap/dist.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2358,7 +2358,7 @@ fn maybe_install_llvm(builder: &Builder<'_>, target: TargetSelection, dst_libdir
}

if let Some(config) = builder.config.target_config.get(&target) {
if config.llvm_config.is_some() {
if config.llvm_config.is_some() && !builder.config.llvm_from_ci {
// If the LLVM was externally provided, then we don't currently copy
// artifacts into the sysroot. This is not necessarily the right
// choice (in particular, it will require the LLVM dylib to be in
Expand All @@ -2369,6 +2369,9 @@ fn maybe_install_llvm(builder: &Builder<'_>, target: TargetSelection, dst_libdir
// with the wrong files and isn't what distributions want.
//
// This behavior may be revisited in the future though.
//
// If the LLVM is coming from ourselves (just from CI) though, we
// still want to install it, as it otherwise won't be available.
return;
}
}
Expand Down

0 comments on commit f4d014c

Please sign in to comment.