Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MinMaxResult: derive Eq #838

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

Philippe-Cholet
Copy link
Member

@Philippe-Cholet Philippe-Cholet commented Jan 10, 2024

I merely did cargo clippy --fix -- -D clippy::derive_partial_eq_without_eq but the next link is useful to understand why it should be done
https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

Credits to #618.

I merely did `cargo clippy --fix -- -D clippy::derive_partial_eq_without_eq` but the next link is useful to understand why it should be done
https://rust-lang.github.io/rust-clippy/master/index.html#derive_partial_eq_without_eq

Co-Authored-By: Marcel Hellwig <[email protected]>
Copy link
Member

@phimuemue phimuemue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Thanks.

@phimuemue phimuemue enabled auto-merge January 10, 2024 14:23
@phimuemue phimuemue added this pull request to the merge queue Jan 10, 2024
Merged via the queue into rust-itertools:master with commit a22553e Jan 10, 2024
8 checks passed
@Philippe-Cholet Philippe-Cholet deleted the eq-minmax branch January 10, 2024 14:26
@Philippe-Cholet Philippe-Cholet added this to the next milestone Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants