Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump secp256k1-sys version to 0.7.0 #549

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

tcharding
Copy link
Member

We are ready to release a new minor version of secp256k1-sys, in order to do so we must make change the symbol names to reflect the new version as well as the usual changelog and version bump.

In preparation for releasing secp256k1-sys v0.7.0 do:

  • Rename symbols to from 0_6_1 -> 0_7_0, done mechanically (search and replace)
  • Add changes log notes
  • Bump secp256k1-sys crate version 0.6.1 -> 0.7.0, justified because we have added new public methods to various types (e.g., PublicKey::cmp_fast_unstable)

Notes

I based this PR on:

@tcharding tcharding force-pushed the 12-01-secp-sys-release branch from 8aea626 to 45beac7 Compare November 30, 2022 23:48
@tcharding
Copy link
Member Author

tcharding commented Nov 30, 2022

@apoelstra I did #550 so that we can merge this PR, tag and release secp256k1-sys, then merge #550 and then tag/release secp256k1 v0.25.0, keeping the index nice and clean ... I think

@apoelstra
Copy link
Member

I'm unsure now if we want to hold off on this release until we've dealt with #543 and #546

@tcharding
Copy link
Member Author

Lets do them both :)

@Kixunil
Copy link
Collaborator

Kixunil commented Dec 4, 2022

Actually, since this bumps -sys crate it is unrelated to #543 and may be merged independently. But that one is really close to merging anyway.

@apoelstra
Copy link
Member

@tcharding ok, now I think this is the only thing blocking release of 0.25.0 :). But it needs rebase.

We are ready to release a new minor version of `secp256k1-sys`, in order
to do so we must make change the symbol names to reflect the new version
as well as the usual changelog and version bump.

In preparation for releasing `secp256k1-sys` v0.7.0 do:

- Rename symbols to from `0_6_1` -> `0_7_0`, done mechanically (search
  and replace)
- Add changes log notes
- Bump `secp256k1-sys` crate version 0.6.1 -> 0.7.0, justified because
  we have added new public methods to various types (e.g.,
  `PublicKey::cmp_fast_unstable`)
@tcharding tcharding force-pushed the 12-01-secp-sys-release branch from 45beac7 to 3fa2436 Compare December 11, 2022 22:13
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3fa2436

@apoelstra apoelstra merged commit 3a1fd2d into rust-bitcoin:master Dec 12, 2022
@apoelstra
Copy link
Member

Tagged and published secp-sys.

@tcharding tcharding deleted the 12-01-secp-sys-release branch December 15, 2022 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants