Replace dangerous cargo features with rustc flags #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature was not useful for Cargo users, since Cargo does not give you the kind of fine-grained control over C library linkage that you need. So it was just unnecessarily confusing and would cause the build to break if you enabled it accidentally, say, with --all-features.
It's super dangerous to use Cargo features for this, since they can be set accidentally (or maliciously by any crate in a user's entire dep tree). Instead we can just require users set `RUSTFLAGS` appropriately, which we can easily do in our fuzzing scripts.
apoelstra
force-pushed
the
2020-12--no-extsymb
branch
from
2c872d5 to
85075a6
Compare
apoelstra
changed the title
external-symbols feature
elichai
reviewed
Dec 22, 2020
Comment on lines
-29
to
-33
| if cfg!(feature = "external-symbols") { | ||
| println!("cargo:rustc-link-lib=static=secp256k1"); | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
We don't want to leave if cfg!("rust_secp_no_symbol_renaming") here?
There was a problem hiding this comment.
No, all this does is set a flag that Cargo understands ... but if you are using Cargo then you shouldn't be using this flag, since you'll get symbol collisions and other messy results.
elichai
approved these changes
Dec 22, 2020
This was referenced Jan 11, 2021
apoelstra
added a commit
to BlockstreamResearch/rust-secp256k1-zkp
that referenced
this pull request
Jun 10, 2024
In secp256k1-sys we replaced this feature with a cfg flag back in rust-bitcoin/rust-secp256k1#263 ... here we got rid of the feature but retained the feature-gate, making the functionality useless. While we are at it, whitelist the cfg flags that we _do_ use.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @TheBlueMatt
For Core integration you now need to add
--cfg=rust_secp_no_symbol_renamingto your rustc flags rather than--cfg=features=external-symbols.For fuzzing you need to add
--cfg=rust_secp_fuzzrather than--cfg=features=fuzztarget. Our downstream fuzzing scripts will need to be adjusted.