Add codespell support: config, github workflow (to detect future typos) + make it fix some typos #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rusq
requested changes
Mar 1, 2024
There was a problem hiding this comment.
Hey @yarikoptic , thank you for your contribution, I quite like this, did not know that I had so many typos! One minor comment for your consideration, please see below
auth/browser.go
Outdated
| @@ -63,11 +63,11 @@ func NewBrowserAuth(ctx context.Context, opts ...Option) (BrowserAuth, error) { | |||
| } else { | |||
| br.opts.workspace = wsp | |||
| } | |||
| auther, err := browser.New(br.opts.workspace, browser.OptBrowser(br.opts.browser), browser.OptTimeout(br.opts.loginTimeout), browser.OptVerbose(br.opts.verbose)) | |||
| author, err := browser.New(br.opts.workspace, browser.OptBrowser(br.opts.browser), browser.OptTimeout(br.opts.loginTimeout), browser.OptVerbose(br.opts.verbose)) | |||
There was a problem hiding this comment.
Can this be added to ignores too please?
There was a problem hiding this comment.
oh, I should have read more of context here to understand what was wanted.
I will add it to skip.
There was a problem hiding this comment.
rebased, redone, force-pushed
=== Do not change lines below ===
{
"chain": [],
"cmd": "codespell -w",
"exit": 0,
"extra_inputs": [],
"inputs": [],
"outputs": [],
"pwd": "."
}
^^^ Do not change lines above ^^^
yarikoptic
force-pushed
the
enh-codespell
branch
from
b8614fb to
7f9ff15
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more on codespell: https://github.com/codespell-project/codespell