Add a minimum ruby version to the generated gemspec #7209
Conversation
|
@bundlerbot r=hsbt |
7209: Add a minimum ruby version to the generated gemspec r=hsbt a=deivid-rodriguez This PR is a finished version of #4397. ### What was the end-user problem that led to this PR? The problem was that the generated gemspec for new gems does not impose a minimum ruby version. ### What is your fix for the problem, implemented in this PR? My fix is to set the minimum ruby version in the generated gemspec to the minimum ruby version supported by bundler itself. ### Why did you choose this fix out of the possible options? I chose this fix because it's simple. Co-authored-by: David Rodríguez <[email protected]> Co-authored-by: Miklos Fazekas <[email protected]>
| @@ -12,6 +12,7 @@ Gem::Specification.new do |spec| | |||
| <%- if config[:mit] -%> | |||
| spec.license = "MIT" | |||
| <%- end -%> | |||
| spec.required_ruby_version = Gem::Requirement.new(">= 2.3.0") | |||
There was a problem hiding this comment.
If I understand it will, this should be the same as https://github.com/bundler/bundler/blob/c5dcdfbc3617d1ecf551f047456d4ea03a18f930/bundler.gemspec#L34. But to prevent loading bundler gemspec during generating new gem, this is hardcoded in here, but covered by spec ensuring those two values are the same.
There was a problem hiding this comment.
Yes, although I didn't really consider your alternative solution: load bundler's gemspec, and load the minimum version from there. It sounds like it might be a better approach since it's more DRY and we don't need a spec to keep the minimum versions in sync... 🤔.
There was a problem hiding this comment.
Ahh, I was thinking loading bundler's gemspec is overkill during generating new gem. Anyway I can inspect that option if needed. Feel free to ping me.
There was a problem hiding this comment.
Yeah, I don't have a strong opinion, this is probably good enough.
Build succeeded |
ghost
merged commit 
This PR is a finished version of #4397.
What was the end-user problem that led to this PR?
The problem was that the generated gemspec for new gems does not impose a minimum ruby version.
What is your fix for the problem, implemented in this PR?
My fix is to set the minimum ruby version in the generated gemspec to the minimum ruby version supported by bundler itself.
Why did you choose this fix out of the possible options?
I chose this fix because it's simple.