Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specs for suppresssing warnings #804

Merged
merged 4 commits into from
Oct 21, 2020

Conversation

lxxxvi
Copy link
Contributor

@lxxxvi lxxxvi commented Oct 21, 2020

Hello 👋

This PR covers the remaining open tasks in category "Command Line options" from issue #745:

  • It works with the RUBYOPT environment variable:
    ...
  • To suppress experimental feature warnings:
    ...
  • To suppress both by using RUBYOPT, set space separated values:

(The first task in category "Command Line options" has been taken care of in #803 already)

Please let me know if anything has to be changed, thanks.

Commit 28ff1f9 introduced spec for '-W:no-deprecated' CLI option. This commit asserts the same result if the option is defined in the RUBYOPT environment variable.
Commit e5d3e4d introduced spec for '-W:no-experimental' CLI option. This commit asserts the same result if the option is defined in the RUBYOPT environment variable.
Tests that both, deprecation and experimental warnings, are suppressed using `RUBYOPT='-W:no-deprecated -W:no-experimental'` environment variable.
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@eregon eregon merged commit 2642d55 into ruby:master Oct 21, 2020
@lxxxvi lxxxvi deleted the add-specs-for-suppresssing-warnings branch October 22, 2020 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants