Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add warning test when access or set $SAFE #800

Merged
merged 2 commits into from
Oct 16, 2020
Merged

add warning test when access or set $SAFE #800

merged 2 commits into from
Oct 16, 2020

Conversation

kuei0221
Copy link
Contributor

Hi, here is a PR for solving #745, add spec of warning when access or set $SAFE.

  • Access and setting of $SAFE is now always warned. $SAFE
    will become a normal global variable in Ruby 3.0. Feature #16131

eregon
eregon reviewed Oct 16, 2020
View reviewed changes
language/safe_spec.rb Outdated Show resolved Hide resolved
eregon
eregon approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@eregon eregon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eregon eregon merged commit c8bc53a into ruby:master Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eregon eregon eregon approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuei0221 @eregon