Fix upstreamed specs (Dec 2024) #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrykonchin
force-pushed
the
ak/debug-failing-specs
branch
2 times, most recently
from
b8a240e to
5f6459f
Compare
andrykonchin
force-pushed
the
ak/debug-failing-specs
branch
from
5f6459f to
8ff5cfd
Compare
andrykonchin
force-pushed
the
ak/debug-failing-specs
branch
from
8ff5cfd to
5900f86
Compare
andrykonchin
commented
Dec 9, 2024
|
|
||
| platform_is :windows do | ||
| SystemCallError.new(-1).message.should == "The operation completed successfully." | ||
| end |
There was a problem hiding this comment.
Observed strange behaviour on Windows. CRuby calls strerror on Windows to get a string description for errno and it returns unexpected strings for unsupported errno codes (e.g. negative or not listed in https://learn.microsoft.com/en-us/cpp/c-runtime-library/errno-constants)
andrykonchin
changed the title
andrykonchin
force-pushed
the
ak/debug-failing-specs
branch
from
095e1e2 to
5900f86
Compare
andrykonchin
commented
Dec 9, 2024
|
|
||
| io.path.should == "a.txt" | ||
| io.path.should == "a.txt" | ||
| end |
There was a problem hiding this comment.
By some reason specs fail on macOS/Ubintu on CI with error:
-----------------------------------------------------
The rubyspec temp directory is not empty. Ensure that
all specs are cleaning up temporary files:
/Users/runner/work/spec/spec/rubyspec_temp/[59](https://github.com/ruby/spec/actions/runs/12241512394/job/34146769462?pr=1226#step:9:60)61
-----------------------------------------------------
1)
An exception occurred during: after :each
C-API IO function rb_io_open_descriptor sets the specified path ERROR
Errno::EBADF: Bad file descriptor @ fptr_finalize_flush - /Users/runner/work/spec/spec/rubyspec_temp/59[61](https://github.com/ruby/spec/actions/runs/12241512394/job/34146769462?pr=1226#step:9:62)/110-c_api_io_specs
/Users/runner/work/spec/spec/optional/capi/io_spec.rb:218:in `close'
/Users/runner/work/spec/spec/optional/capi/io_spec.rb:218:in `block (2 levels) in <top (required)>'
/Users/runner/work/spec/spec/optional/capi/io_spec.rb:205:in `<top (required)>'
Cannot reproduce it locally. So I decided just to quarantine them until the issue is investigated.
https://github.com/ruby/spec/actions/runs/12241512394/job/34146769462
https://github.com/ruby/spec/actions/runs/12241608299/job/34147078428
andrykonchin
force-pushed
the
ak/debug-failing-specs
branch
from
d1edff6 to
749826e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.