Skip to content

Commit

Permalink
Increase timeout on macOS
Browse files Browse the repository at this point in the history
* security/cve_2020_10663_spec.rb seems to often take > 30 seconds there,
  which is very surprising as it takes 5ms locally on Linux.
  https://github.com/ruby/spec/pull/795/checks?check_run_id=1230499776
  • Loading branch information
eregon committed Oct 10, 2020
1 parent 6ce0727 commit ac60ece
Showing 1 changed file with 14 additions and 6 deletions.
20 changes: 14 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,18 @@ jobs:
- name: Clone MSpec
run: git clone https://github.com/ruby/mspec.git ../mspec

- name: Run specs
if: matrix.os != 'windows'
- name: Run specs (Linux)
if: matrix.os == 'ubuntu'
env:
CHECK_LEAKS: true
run: ../mspec/bin/mspec --timeout 30
- name: Run C-API specs as C++
if: matrix.os != 'windows'

- name: Run specs (macOS)
if: matrix.os == 'macos'
env:
SPEC_CAPI_CXX: true
run: ../mspec/bin/mspec :capi
CHECK_LEAKS: true
# Use a larger timeout on macOS since it seems to have less reliable performance
run: ../mspec/bin/mspec --timeout 60

- name: Run specs (Windows)
if: matrix.os == 'windows'
Expand All @@ -44,6 +46,12 @@ jobs:
[Console]::InputEncoding = [System.Text.Encoding]::GetEncoding("IBM437")
../mspec/bin/mspec -j
- name: Run C-API specs as C++
if: matrix.os != 'windows'
env:
SPEC_CAPI_CXX: true
run: ../mspec/bin/mspec :capi

rubocop:
name: RuboCop
runs-on: ubuntu-latest
Expand Down

0 comments on commit ac60ece

Please sign in to comment.