-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract TruffleRuby workflow from reline.yml #783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The build doesn't actually run tho: https://github.com/ruby/reline/actions/runs/12053375836
ruby-versions: | ||
uses: ruby/actions/.github/workflows/ruby_versions.yml@master | ||
with: | ||
engine: truffleruby |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may be wrong, but I don't think there's a truffleruby engine.
Yes I'm wrong. I'll update IRB's action.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I'm wrong on being wrong 🤦♂️
If we use the setup-ruby
action, then truffleruby
is indeed supported. But since we're using ruby_versions
, I think only these are supported.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your review! I've fixed.
engine: cruby-truffleruby
ruby: [truffleruby-head]
fail-fast: false | ||
matrix: | ||
ruby: ${{ fromJson(needs.ruby-versions.outputs.versions) }} | ||
os: [ubuntu-latest, macos-latest, windows-latest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the below exclusions, we'll only run ubuntu-latest
after all. Maybe let's just update this list to that and remove the excludes?
a39b7c9
to
0043baf
Compare
0043baf
to
cbc95ac
Compare
on: | ||
push: | ||
pull_request: | ||
workflow_dispatch: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made it possible to check the CI status manually.
strategy: | ||
fail-fast: false | ||
matrix: | ||
ruby: [truffleruby-head] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
truffleruby-head
was originally excluded, but since it can now be easily stopped, it has been set to truffleruby-head
.
env: | ||
TERM: xterm-256color | ||
run: bundle exec rake test RUBYOPT="--enable-frozen-string-literal" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Readline tests were removed because they were not being run on TruffleRuby.
Background: ruby/irb#1032
Ref: ruby/irb#1035
Similar to IRB, I have separated the TruffleRuby workflow from reline.yml.