Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract TruffleRuby workflow from reline.yml #783

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

ima1zumi
Copy link
Member

Background: ruby/irb#1032
Ref: ruby/irb#1035

Similar to IRB, I have separated the TruffleRuby workflow from reline.yml.

Copy link
Member

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ruby-versions:
uses: ruby/actions/.github/workflows/ruby_versions.yml@master
with:
engine: truffleruby
Copy link
Member

@st0012 st0012 Nov 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be wrong, but I don't think there's a truffleruby engine.

Yes I'm wrong. I'll update IRB's action.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I'm wrong on being wrong 🤦‍♂️
If we use the setup-ruby action, then truffleruby is indeed supported. But since we're using ruby_versions, I think only these are supported.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your review! I've fixed.

engine: cruby-truffleruby
ruby: [truffleruby-head]

fail-fast: false
matrix:
ruby: ${{ fromJson(needs.ruby-versions.outputs.versions) }}
os: [ubuntu-latest, macos-latest, windows-latest]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the below exclusions, we'll only run ubuntu-latest after all. Maybe let's just update this list to that and remove the excludes?

@ima1zumi ima1zumi force-pushed the extract-truffleruby-workflow branch 2 times, most recently from a39b7c9 to 0043baf Compare November 27, 2024 16:46
@ima1zumi ima1zumi force-pushed the extract-truffleruby-workflow branch from 0043baf to cbc95ac Compare November 27, 2024 16:48
on:
push:
pull_request:
workflow_dispatch:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made it possible to check the CI status manually.

strategy:
fail-fast: false
matrix:
ruby: [truffleruby-head]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

truffleruby-head was originally excluded, but since it can now be easily stopped, it has been set to truffleruby-head.

env:
TERM: xterm-256color
run: bundle exec rake test RUBYOPT="--enable-frozen-string-literal"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readline tests were removed because they were not being run on TruffleRuby.

@ima1zumi ima1zumi merged commit 528f412 into ruby:master Nov 28, 2024
41 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants