Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #13374] Return exit code 0 with --display-only-correctable and --display-only-safe-correctable when no offenses are displayed #13375

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

dvandersluis
Copy link
Member

When --display-only-correctable or --display-only-safe-correctable is specified, and therefore no offenses are included that'd otherwise be shown, return exit code 0 instead of 1.

Fixes #13374.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

…le` and `--display-only-safe-correctable` when no offenses are displayed.
@koic koic merged commit f3aa4fb into rubocop:master Oct 23, 2024
22 checks passed
@koic
Copy link
Member

koic commented Oct 23, 2024

Thanks!

@dvandersluis dvandersluis deleted the issue/13374 branch October 23, 2024 16:56
@vasil-nesterov
Copy link

Thank you Daniel!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exit status is inconsistent with the output when --display-only-correctable is on
3 participants