-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style/RedundantRegexpArgument uses double quotes #13099
Labels
Comments
koic
added a commit
to koic/rubocop
that referenced
this issue
Aug 8, 2024
…hes` Fixes rubocop#13099. This PR fixes an error for `Style/IdenticalConditionalBranches` when handling empty case branches.
8 tasks
Man, you are fast... |
koic
added a commit
to koic/rubocop
that referenced
this issue
Aug 8, 2024
…`EnforcedStyle` of `Style/StringLiterals` Fixes rubocop#13099. This PR makes `Style/RedundantRegexpArgument` respect the `EnforcedStyle` of `Style/StringLiterals`. Also, combine the way to get the `EnforcedStyle` from `Style/StringLiterals` into `StringLiteralHelp`.
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this issue
Aug 8, 2024
…`EnforcedStyle` of `Style/StringLiterals` Fixes rubocop#13099. This PR makes `Style/RedundantRegexpArgument` respect the `EnforcedStyle` of `Style/StringLiterals`. Also, combine the way to get the `EnforcedStyle` from `Style/StringLiterals` into `StringLiteralHelp`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
That cops performs the conversion to string, but uses double quotes when single quotes would suffice, so it fires Style/StringLiterals.
Expected behavior
Use single quotes by default, or whatever Style/StringLiterals was configured for.
Actual behavior
See above the result of
bundle exec rubocop -x --only Style/RedundantRegexpArgument
.Steps to reproduce the problem
See above.
RuboCop version
The text was updated successfully, but these errors were encountered: