Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New cop that detects operations with constant results #11191

Closed
fatkodima opened this issue Nov 19, 2022 · 0 comments · Fixed by #13186
Closed

New cop that detects operations with constant results #11191

fatkodima opened this issue Nov 19, 2022 · 0 comments · Fixed by #13186

Comments

@fatkodima
Copy link
Contributor

fatkodima commented Nov 19, 2022 •
edited
Loading

Inspired by https://hexdocs.pm/credo/Credo.Check.Warning.OperationWithConstantResult.html

It should check for the code like

x * 1
x * 0
x / 1
x ** 0
x ** 1
x % 1

This is almost always a mistake (or just left after debugging, probably) or just redundant code.
Zopolis4 added a commit to Zopolis4/rubocop that referenced this issue Jul 29, 2024
@Zopolis4
Add new Lint/UselessNumericOperation cop
20cb339 
Makes progress on rubocop#11191.

Certain numeric operations have no impact, being:
Adding or subtracting 0, multiplying or dividing by 1 or raising to the power of 1.

These are probably mistakes or leftover from debugging, so flag and optionally remove them.
Zopolis4 added a commit to Zopolis4/rubocop that referenced this issue Jul 29, 2024
@Zopolis4
Add new Lint/UselessNumericOperation cop
2826cf7 
Makes progress on rubocop#11191.

Certain numeric operations have no impact, being:
Adding or subtracting 0, multiplying or dividing by 1 or raising to the power of 1.

These are probably mistakes or leftover from debugging, so flag and optionally remove them.
@Zopolis4 Zopolis4 mentioned this issue Jul 29, 2024
Merged
8 tasks
Zopolis4 added a commit to Zopolis4/rubocop that referenced this issue Aug 27, 2024
@Zopolis4
Add new Lint/UselessNumericOperation cop
b05a51c 
Makes progress on rubocop#11191.

Certain numeric operations have no impact, being:
Adding or subtracting 0, multiplying or dividing by 1 or raising to the power of 1.

These are probably mistakes or leftover from debugging, so flag and optionally remove them.
bbatsov pushed a commit that referenced this issue Aug 31, 2024
@Zopolis4 @bbatsov
Add new Lint/UselessNumericOperation cop
1e4b4c8 
Makes progress on #11191.

Certain numeric operations have no impact, being:
Adding or subtracting 0, multiplying or dividing by 1 or raising to the power of 1.

These are probably mistakes or leftover from debugging, so flag and optionally remove them.
Zopolis4 added a commit to Zopolis4/rubocop that referenced this issue Sep 3, 2024
@Zopolis4
[Fix rubocop#11191] Add new Lint/NumericOperationWithConstantResult…
f3b7bc3 
… cop
@Zopolis4 Zopolis4 mentioned this issue Sep 3, 2024
Merged
8 tasks
Zopolis4 added a commit to Zopolis4/rubocop that referenced this issue Sep 3, 2024
@Zopolis4
[Fix rubocop#11191] Add new Lint/NumericOperationWithConstantResult…
9b7bab0 
… cop
Zopolis4 added a commit to Zopolis4/rubocop that referenced this issue Sep 9, 2024
@Zopolis4
[Fix rubocop#11191] Add new Lint/NumericOperationWithConstantResult…
77b30af 
… cop
Zopolis4 added a commit to Zopolis4/rubocop that referenced this issue Sep 17, 2024
@Zopolis4
[Fix rubocop#11191] Add new Lint/NumericOperationWithConstantResult…
0300096 
… cop
Zopolis4 added a commit to Zopolis4/rubocop that referenced this issue Nov 1, 2024
@Zopolis4
[Fix rubocop#11191] Add new Lint/NumericOperationWithConstantResult…
cfd5af0 
… cop
Zopolis4 added a commit to Zopolis4/rubocop that referenced this issue Nov 7, 2024
@Zopolis4
[Fix rubocop#11191] Add new Lint/NumericOperationWithConstantResult…
8d30a75 
… cop
Zopolis4 added a commit to Zopolis4/rubocop that referenced this issue Nov 7, 2024
@Zopolis4
[Fix rubocop#11191] Add new Lint/NumericOperationWithConstantResult…
8db6037 
… cop
bbatsov pushed a commit that referenced this issue Nov 7, 2024
@Zopolis4 @bbatsov
[Fix #11191] Add new Lint/NumericOperationWithConstantResult cop
8330a6e
@linyclar linyclar mentioned this issue Dec 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fix #11191] Add new Lint/NumericOperationWithConstantResult cop Zopolis4/rubocop
1 participant
@fatkodima