Fix Rails/CompactBlank to avoid reporting offense for filter in R…

…uby versions below 2.6
rubocop · Sep 11, 2024 · 155abd0 · 155abd0
1 parent 5fbb05d
commit 155abd0
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/lib/rubocop/cop/rails/compact_blank.rb b/lib/rubocop/cop/rails/compact_blank.rb
@@ -80,6 +80,7 @@ class CompactBlank < Base
         PATTERN
 
         def on_send(node)
+          return if target_ruby_version < 2.6 && node.method?(:filter)
           return unless bad_method?(node)
 
           range = offense_range(node)

diff --git a/spec/rubocop/cop/rails/compact_blank_spec.rb b/spec/rubocop/cop/rails/compact_blank_spec.rb
@@ -257,6 +257,14 @@ def foo(arg)
         collection.filter { |e| e.blank? }
       RUBY
     end
+
+    context 'target_ruby_version < 2.6', :ruby25, unsupported_on: :prism do
+      it 'does not register an offense when using `filter { |e| e.present? }`' do
+        expect_no_offenses(<<~RUBY)
+          collection.filter { |e| e.present? }
+        RUBY
+      end
+    end
   end
 
   context 'Rails <= 6.0', :rails60 do