Error in curl::curl_fetch_memory(url, handle = handle) : <url> malformed

[shalutiwari]

Getting this error when running below mytest.R . Error goes away when download lines are commented.

app <- ShinyDriver$new("../", shinyOptions = list(display.mode = "normal"))
app$snapshotInit("mytest")

app$snapshot()
app$snapshot()
app$snapshot()
app$setInputs(sanitize = "TRUE")
app$snapshot()
app$snapshotDownload("downloadData")
app$setInputs(safe = "TRUE")
app$snapshotDownload("downloadData")

recordTest('110-error-sanitization',shinyOptions = list(display.mode="normal"))
Loading required package: shiny

Listening on http://127.0.0.1:7073
Saved test code to /Users/shalutiwari/shiny-examples-branch/shiny-examples/110-error-sanitization/tests/mytest.R
Running mytest.R Error in curl::curl_fetch_memory(url, handle = handle) : <url> malformed

[hadley]

I don't see any error when running:

path <- "../shiny-examples/110-error-sanitization"
shinytest::recordTest(path)

So maybe it's that test that's the problem? Ok, yes, this generates the error:

path <- "../shiny-examples/110-error-sanitization"
dir.create(file.path(path, "tests", "shinytest"), recursive = TRUE)
writeLines(con = file.path(path, "tests", "shinytest", "mytest.R"),  '
app <- ShinyDriver$new("../../")
app$snapshotInit("mytest")
app <- ShinyDriver$new("../../")
app$snapshotInit("mytest")
app$snapshotDownload("downloadData")
')
shinytest::testApp(path)

[hadley]

And this is because self$findElement(paste0("#", id))$getAttribute("href") returns "". So we need to provide an informative error here, either checking that href exists or checking that httr::GET() succeeds (or both).

[hadley]

Same underlying cause as #195

[hadley]

Simpler reprex:

app <- ShinyDriver$new("../shiny-examples/110-error-sanitization")
app$snapshotInit("mytest")
app$snapshotDownload("downloadData")