Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shadow DOM compatibility #529

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

jcheng5
Copy link
Member

@jcheng5 jcheng5 commented Apr 8, 2020

This rule sets the default font not only for the root html
element, but also for the host of the shadow DOM, if any.

This rule sets the default font not only for the root html
element, but also for the host of the shadow DOM, if any.
@jcheng5 jcheng5 requested a review from rich-iannone April 14, 2020 19:44
rich-iannone
rich-iannone previously approved these changes Apr 14, 2020
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. The failed builds have entirely to do with a different issue (gtsave()) that we expect will be resolved soon.

Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved once before and now up to date with master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants