-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix focusSearchField(), fixes #374. Removes gear icon (and compose when too small), fixes #264, #313, #387, #402 #381
base: master
Are you sure you want to change the base?
Conversation
# Conflicts: # Messenger/AppDelegate.mm
Messenger/AppDelegate.mm
Outdated
DISABLE(webGLEnabled); | ||
>>>>>>> rsms/master | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L127 - L131: I may be wrong, but did you mean to keep this there? (Referring to the merge conflict messages)
Missed conflicts in appdelegate
This is great. Could you please explain how this fixes #346? I don't see the correlation. |
Yes, this is a fix for #374. I don't know if it's still working, it's based on the assumption that the searchfield is the first element found by the query so it's in no way bulletproof. |
This disables the overscroll of the UI which gives the app a very non-native look
Using a different selector and css I no longer experience any issues with the gear icon being visible beneath the window controls
Added more commits, should now fix #264, #313, #387, #402. The gear is no longer showing at all when I use the app. I removed overscroll of the UI since it was giving the app a very non-native feel when you could scroll the entire frame. I also included a working fix for #399 since there's not been an update yet. |
Any update on this? |
No description provided.