Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix focusSearchField(), fixes #374. Removes gear icon (and compose when too small), fixes #264, #313, #387, #402 #381

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

hampustagerud
Copy link
Contributor

No description provided.

@hampustagerud hampustagerud changed the title Fix focusSearchField() Fix focusSearchField(), fixes #374 Apr 9, 2017
@hampustagerud hampustagerud reopened this Apr 9, 2017
DISABLE(webGLEnabled);
>>>>>>> rsms/master

Copy link

@him229 him229 Apr 13, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L127 - L131: I may be wrong, but did you mean to keep this there? (Referring to the merge conflict messages)

Missed conflicts in appdelegate
@rsms
Copy link
Owner

rsms commented Jul 31, 2017

This is great. Could you please explain how this fixes #346? I don't see the correlation.

@him229
Copy link

him229 commented Jul 31, 2017

@rsms this is a fix for #374

@hampustagerud
Copy link
Contributor Author

Yes, this is a fix for #374. I don't know if it's still working, it's based on the assumption that the searchfield is the first element found by the query so it's in no way bulletproof.

This disables the overscroll of the UI which gives the app a very
non-native look
Using a different selector and css I no longer experience any issues
with the gear icon being visible beneath the window controls
@hampustagerud
Copy link
Contributor Author

hampustagerud commented Aug 10, 2017

Added more commits, should now fix #264, #313, #387, #402. The gear is no longer showing at all when I use the app. I removed overscroll of the UI since it was giving the app a very non-native feel when you could scroll the entire frame.

I also included a working fix for #399 since there's not been an update yet.

@hampustagerud hampustagerud changed the title Fix focusSearchField(), fixes #374 Fix focusSearchField(), fixes #374. Removes gear icon (and compose when too small), fixes #264, #313, #387, #402 Aug 10, 2017
@dylankolson
Copy link

Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants