Update primary_key method arguments to fix issue with *args causing wrong number of arguments error #2358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rong number of arguments error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have found that currently when a migration invokes the primary_key method in
schema_statements.rbe.gt.primary_key :zlookupid, :string, limit: 1, null: false, it causes the following wrong number of arguments error:Based on the use of keyword arguments in the other primary_key method definition in
schema_definitions.rb, we think that this should be the same in theschema_statements.rbdefinition rather than using*argsin the definition andsupercall.We have added a local fix to get around this but wonder if this may be an issue that other's will face.