-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create sub-modules for examples and wrappers #67
Conversation
wrapper/go.mod
Outdated
@@ -0,0 +1,22 @@ | |||
module github.com/rs/cors/wrapper/gin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@komuw: shouldn't this file be at wrapper/gin
level?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rs agreed.
I have done that now.
@rs I do not know if you want one |
When running
How do you test this? |
inside github.com/rs/cors/wrapper/gin , replace github.com/rs/cors with the relative path to the co-located github.com/rs/cors package. see: golang/go#27056
@rs the commands: go test -count=1 ./... && \
cd wrapper/gin && \
go test -count=1 ./... && \
cd ../.. ok github.com/rs/cors 0.004s
ok github.com/rs/cors/wrapper/gin 0.004s now works. However the command; cd examples && \
go test -count=1 ./... && \
cd .. doesn't succeed. Line 7 in 9a47f48
which seems to indicate that maybe the replace directive: https://github.com/rs/cors/pull/67/files#diff-8d6f6299a802b70c5794f4ed12c66ce2R26 is not working. To be honest, this has turned out quite harder than I thought it would. I'll keep probing to see if I can get the examples folder to play cool |
also: golang/go#27957 |
this investigation has led me to discover something else; |
No description provided.