Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds -f flag to use a custom CSV [f]ile of barcodes. #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sclamons
Copy link

@sclamons sclamons commented Feb 4, 2018

Adds the ability to use custom barcodes defined in a (user-specified) CSV file using a -f flag.

If the flag is on, the first thing porechop.py does is to parse the CSV file into a list of Adapter objects, then append that list to the end of the list of Adapters from adapter.py.

@kyrubas
Copy link

kyrubas commented May 23, 2018

@rrwick, first off- great repository. Second, any thoughts on merging this into the main repo? As I would rather not alter the hard-coded adapters file, I'm going to clone this fork for now as it solves my use case.
@sclamons, what are your thoughts on adding a second argument to completely over-ride the default adapters rather than append them to the list? Or even having the defaults as a default csv that gets generated into a list of adapter objects rather than a *.py file.

@callumparr callumparr mentioned this pull request Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants