Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UserSet commented out in DomainObjectWrapper #15

Open
rreganjr opened this issue Mar 19, 2018 · 1 comment
Open

UserSet commented out in DomainObjectWrapper #15

rreganjr opened this issue Mar 19, 2018 · 1 comment
Assignees
@rreganjr
Labels
refactor non-functional code changes tech debt
Milestone
1.0.3

Comments

@rreganjr
Copy link
Owner

When DomainObjectWrapper was moved to the new repository module it had references to UserSet in the requel module, but the dependencies of the modules would be cyclical so I commented out references to UserSet, there were notes that it may not be needed.
@rreganjr rreganjr added refactor non-functional code changes tech debt labels Mar 19, 2018
@rreganjr rreganjr self-assigned this Mar 19, 2018
rreganjr added a commit that referenced this issue Mar 19, 2018
@rreganjr
https://github.com/rreganjr/Requel/issues/7
e07df7c 
#8
#13
#15
branch 1.0.3

I added exception module and moved some exceptions to it, I removed RequelException and just use ApplicationException isntead. most are at the root level com.rreganjr.
I added initializer module and moved the SystemInitializer and AbstractSystemInitializer to it. I split this because both nlp and requel use it.
I added repository module and moved the repository package to it. I split this because both nlp and requel use it.
I added nlp module and moved the nlp package to it.

I removed the UserSet/UserSetImpl and replaced with Set<User> and TreeSet<User>

Signed-off-by: rreganjr <[email protected]>
@rreganjr
Copy link
Owner Author

branch 1.0.3

I added exception module and moved some exceptions to it, I removed RequelException and just use ApplicationException isntead. most are at the root level com.rreganjr.
I added initializer module and moved the SystemInitializer and AbstractSystemInitializer to it. I split this because both nlp and requel use it.
I added repository module and moved the repository package to it. I split this because both nlp and requel use it.
I added nlp module and moved the nlp package to it.

I removed the UserSet/UserSetImpl and replaced with Set and TreeSet

@rreganjr rreganjr added this to the 1.0.3 milestone Apr 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rreganjr rreganjr

Labels
refactor non-functional code changes tech debt
Projects
None yet
Milestone
1.0.3
Development

No branches or pull requests
1 participant
@rreganjr