Fix foreign-scalar-p for unions with no members #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Union types with no members were being called scalar by `foreign-scalar-p` when they had no members. Since it cannot be determined if they are scalar or not, it its more correct to classify them as non-scalar. This fixes a bug where unions with no members were causing an error and preventing files from being imported correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Union types with no members were being called scalar by
foreign-scalar-pwhen they had no members. Since it cannot bedetermined if they are scalar or not, it its more correct to classify
them as non-scalar.
This fixes a bug where unions with no members were causing an error and
preventing files from being imported correctly.