Detect wayland and make sure X rendering is used. #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rviz2 does not work under wayland unless using X compatibility. The current workaround on wayland is to set the QT_QPA_PLATFORM environment variable to xcb. This patch now detects if rviz2 is started in a wayland session and if so sets that variable automatically. Signed-off-by: Matthew Elwin <[email protected]>
ahcorde
approved these changes
Jul 26, 2024
There was a problem hiding this comment.
This is a workaround, that I'm fine with it for now, but we should work on natively support Wayland. @clalancette anything else to add ?
- Linux
- Linux-aarch64
- Linux-rhel
- Windows
No, seems reasonable to me for now. I think we should also backport this to Jazzy. |
|
https://github.com/Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jul 26, 2024
rviz2 does not work under wayland unless using X compatibility. The current workaround on wayland is to set the QT_QPA_PLATFORM environment variable to xcb. This patch now detects if rviz2 is started in a wayland session and if so sets that variable automatically. Signed-off-by: Matthew Elwin <[email protected]> (cherry picked from commit 72c0826)
ahcorde
pushed a commit
that referenced
this pull request
Jul 26, 2024
rviz2 does not work under wayland unless using X compatibility. The current workaround on wayland is to set the QT_QPA_PLATFORM environment variable to xcb. This patch now detects if rviz2 is started in a wayland session and if so sets that variable automatically. Signed-off-by: Matthew Elwin <[email protected]> (cherry picked from commit 72c0826) Co-authored-by: Matthew Elwin <[email protected]>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch causes rviz to detect Wayland and sets it to X compatibility mode, enabling it to run under Wayland.
Currently rviz2 does not support wayland (Issue #847), meaning that rviz2 crashes (e.g., issue #1227, #1245) for Wayland users unless they do a manual workaround.
The current workaround of setting QT_QPA_PLUGIN has a few issues that make it less than ideal: