-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Service generator does not create symbol name for rosidl_typesupport_cpp #122
Labels
Comments
StefanFabian
changed the title
Service generator does not create symbol name for rosidl_type
Service generator does not create symbol name for rosidl_typesupport_introspection_cpp
Apr 9, 2021
StefanFabian
changed the title
Service generator does not create symbol name for rosidl_typesupport_introspection_cpp
Service generator does not create symbol name for rosidl_typesupport_cpp
Apr 12, 2021
@StefanFabian good catch! The service typesupport symbol is missing from |
Any update on what's missing to get these PRs merged? @hidmic |
achim-k
added a commit
to foxglove/ros-foxglove-bridge
that referenced
this issue
Feb 7, 2023
**Public-Facing Changes** - Add ROS2 support for calling server-advertised services **Description** Based on #136 - Adds experimental ROS2 support for advertising/unadvertising services and allowing clients to call them - Implements the services spec that was added in foxglove/ws-protocol#344 Implementation details: The main problem is, that symbols from getting the service type support are missing from the `rosidl_typesupport_cpp` libraries that are generated for each msg/srv package (see ros2/rosidl_typesupport#122). There is an open pull request (ros2/rosidl_typesupport#114) to fix that, but so far it hasn't been merged. I found a working, yet little bit hacky, workaround for this problem which is described more in detail here: https://github.com/foxglove/ros-foxglove-bridge/blob/f978c182185e5deda93a6518132b6d3c339dcaeb/ros2_foxglove_bridge/src/generic_client.cpp#L59-L89 All in all, the implementation is working, but I would consider it as experimental for now. I am not sure if this approach would work on windows / mac
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug report
Required Info:
Steps to reproduce issue
Build a service definition
Expected behavior
There should be a symbol
rosidl_typesupport_cpp__get_service_type_support_handle__[package_name]__srv__[interface_name]
Actual behavior
There is no symbol
rosidl_typesupport_cpp__get_service_type_support_handle__[package_name]__srv__[interface_name]
Additional information
rosidl_typesupport_introspection_cpp contains the following:
the same should probably be in rosidl_typesupport_cpp but is missing.
I don't know where exactly this is generated, hence, I can't make a PR for this.
The text was updated successfully, but these errors were encountered: