Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update branch dashing to support Dashing only #17

Merged
merged 6 commits into from
Mar 29, 2021

Conversation

asorbini
Copy link
Collaborator

This PR updates branch dashing to make it buildable only with the Dashing release.

The PR removes all "feature flags" from static_config.hpp, including RMW_CONNEXT_RELEASE and any code meant to support later releases.

The code was changed assuming the following "feature configuration":

Feature Value
RMW_CONNEXT_RELEASE RMW_CONNEXT_RELEASE_DASHING
RMW_CONNEXT_HAVE_PKG_RMW_DDS_COMMON 0
RMW_CONNEXT_HAVE_SCOPE_EXIT 0
RMW_CONNEXT_HAVE_GET_DOMAIN 0
RMW_CONNEXT_HAVE_OPTIONS 0
RMW_CONNEXT_HAVE_OPTIONS_PUBSUB 0
RMW_CONNEXT_HAVE_INCOMPATIBLE_QOS 0
RMW_CONNEXT_HAVE_INCOMPATIBLE_QOS_EVENT 0
RMW_CONNEXT_HAVE_LIFESPAN_QOS 0
RMW_CONNEXT_HAVE_MESSAGE_LOST 0
RMW_CONNEXT_HAVE_SERVICE_INFO 0
RMW_CONNEXT_HAVE_LOCALHOST_ONLY 0
RMW_CONNEXT_HAVE_TAKE_SEQ 0
RMW_CONNEXT_HAVE_SECURITY 0
RMW_CONNEXT_HAVE_COMMON_MUTEX 0
RMW_CONNEXT_HAVE_LOAN_MESSAGE 0
RMW_CONNEXT_HAVE_MESSAGE_INFO_TS 0
RMW_CONNEXT_HAVE_GET_INFO_BY_TOPIC 0
RMW_CONNEXT_HAVE_QOS_PROFILE_API 0
RMW_CONNEXT_HAVE_TIME_UTILS 0

Note to reviewers: It would be great to review these changes but they are somewhat trivial. I'm creating this PR mainly to keep track of them for future reference.

Signed-off-by: Andrea Sorbini <[email protected]>
@asorbini
Copy link
Collaborator Author

asorbini commented Mar 26, 2021

CI jobs to validate the changes (note: first time running unit tests for Dashing 🤞🏼):

  • ci_linux:
    • Build Status
    • Build Status
    • Build Status (failed because rmw_connext_cpp was excluded, but rmw_connextdds built successfully)
    • Build Status (up to rmw_connextdds only)

Signed-off-by: Andrea Sorbini <[email protected]>
Imported from ros2/rmw_dds_common (foxy, 79af623280e938b4573cc354d5aeb31444e3f9bd)

Signed-off-by: Andrea Sorbini <[email protected]>
@asorbini
Copy link
Collaborator Author

Backported rmw_dds_common from 79af623

@asorbini asorbini merged commit 7f34843 into dashing Mar 29, 2021
@delete-merged-branch delete-merged-branch bot deleted the asorbini/dashing-no-ff branch March 29, 2021 20:27
@asorbini asorbini added the dashing PR pertaining the Dashing release label Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashing PR pertaining the Dashing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant