history_depth is actually just depth #341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There isn't much documentation on QoS overrides - and many resources that I came across still link back to this (somewhat outdated) design document. Hopefully updating the parameter name here will save some people time in the future. Signed-off-by: Michael Ferguson <[email protected]>
|
For easy reference - this is the commit that implemented the design: ros2/rclcpp@71a58d4 and the qos_overriding_options.hpp has not been altered since |
|
@mjcarroll @sloretz Friendly ping to merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There isn't much documentation on QoS overrides - and many resources that I came across still link back to this (somewhat outdated) design document. Hopefully updating the parameter name here will save some people time in the future.