Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend @key annotation documentation #340

Merged
merged 1 commit into from
May 10, 2024
Merged

Extend @key annotation documentation #340

merged 1 commit into from
May 10, 2024

Conversation

Mario-DL
Copy link
Contributor

This PR extends the @key annotation documentation.

fujitatomoya
fujitatomoya approved these changes Apr 17, 2024
View reviewed changes
Copy link
Collaborator

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

this is related to ros2/ros2#1538

@EduPonz
Copy link

EduPonz commented Apr 18, 2024

@clalancette FYI

@MiguelCompany MiguelCompany mentioned this pull request Apr 18, 2024
Open
@sloretz
Copy link
Contributor

sloretz commented May 10, 2024

@ahcorde @clalancette is this one ready to merge? 🧇

@ahcorde ahcorde merged commit 49bb302 into ros2:gh-pages May 10, 2024
1 check passed
@MiguelCompany MiguelCompany deleted the docs/extend_keys_section branch May 13, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@ahcorde ahcorde ahcorde approved these changes

Assignees

@clalancette clalancette

@ahcorde ahcorde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Mario-DL @EduPonz @sloretz @ahcorde @fujitatomoya @clalancette