Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README #531

Open
lorepieri8 opened this issue Aug 10, 2021 · 17 comments
Open

Add README #531

lorepieri8 opened this issue Aug 10, 2021 · 17 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@lorepieri8
Copy link

It would be good to have a README file for each demo that briefly explains what's inside.

@audrow audrow added good first issue Good for newcomers help wanted Extra attention is needed labels Dec 20, 2021
@audrow
Copy link
Member

audrow commented Dec 20, 2021

I think this is a good idea.

@cardboardcode
Copy link
Contributor

+1 from me as well. I should be available to take a look at this within the month of July 2022 if no one else is doing it.

@lorepieri8 @audrow

Will update accordingly here in this thread regarding progress.

@cardboardcode
Copy link
Contributor

cardboardcode commented Jul 1, 2022

@audrow
Copy link
Member

audrow commented Jul 1, 2022

+1 from me as well. I should be available to take a look at this within the month of July 2022 if no one else is doing it.

@lorepieri8 @audrow

Will update accordingly here in this thread regarding progress.

That'd be great - feel free to @ me for reviews!

@kagibson
Copy link
Contributor

@cardboardcode What is the status with this? I would be happy to work on this or help

@cardboardcode
Copy link
Contributor

@cardboardcode What is the status with this? I would be happy to work on this or help

Hi @kagibson, I have yet to get started. If you like, you can choose from the above list the tasks you wish to work on first. I would simply do the remaining.

Thanks for the offer of help 😊

@cardboardcode
Copy link
Contributor

cardboardcode commented Jul 22, 2022

@kagibson

For now, I will get started doing the following tasks:

Will update in the task list once it is completed.

@cardboardcode
Copy link
Contributor

cardboardcode commented Jul 22, 2022

Hi @audrow, may I get your assistance to review the following added README.mds ?

Thank you.

@kagibson
Copy link
Contributor

@cardboardcode Thank you! I will work on the following:

  • action_tutorials/action_tutorials_cpp/
  • action_tutorials/action_tutorials_interfaces/
  • action_tutorials/action_tutorials_py

@kagibson
Copy link
Contributor

@audrow I'm in the process of writing the readme for the action_tutorials. So far I have an introduction on what is going on in the example. Do we want an in depth description of the code (what each callback is doing etc) or just an explanation of what the demo is doing and how to run it?

@cardboardcode
Copy link
Contributor

@kagibson

Awaiting feedback from @audrow on aforementioned completed README.mds.

Will be starting work on the following new tasks:

@audrow
Copy link
Member

audrow commented Jul 25, 2022

@audrow I'm in the process of writing the readme for the action_tutorials. So far I have an introduction on what is going on in the example. Do we want an in depth description of the code (what each callback is doing etc) or just an explanation of what the demo is doing and how to run it?

@kagibson, I would think that a high level description would be enough, maybe referring to blocks of code and explaining what they're doing. That being said, if you find anything surprising or unintuitive, that's probably a good spot to go into more detail.

@audrow
Copy link
Member

audrow commented Jul 25, 2022

Hi @audrow, may I get your assistance to review the following added README.mds ?

Thank you.

@cardboardcode, thanks for doing those! Would you make a PR for those changes? It'll be an easier way to give you feedback. Probably the easiest way will be to make a PR for each README, since it will be easier to get them in one at a time as they're ready, rather than waiting on all of them to look good all at once.


Edit: I see the PR (#531). It'd be much nicer to split this up into several PRs, since I assume some of it is ready for feedback. (I generally don't look at PRs that are in draft mode.)

@cardboardcode
Copy link
Contributor

cardboardcode commented Jul 26, 2022

@audrow. Noted. Will close PR (#570) and spilt the newly added README.mds into their own individual Pull Requests.

@kagibson
Copy link
Contributor

@audrow I've created a PR (#576) for the action_tutorials README's. Thank you!

@SrijaneeBiswas
Copy link

@lorepieri8 @audrow Any more help wanted on this?

Would love to contribute as a first issue.

@audrow
Copy link
Member

audrow commented Mar 27, 2023

Hi @SrijaneeBiswas, thanks for asking and sorry for the slow reply. I'm not aware of much in this repo that needs improvements, @cardboardcode has done a great job.

However, there are plenty of things that could use improvement in the ros2_documentation repo. Here's a list of issues with help wanted. If you want to try any of them, feel free to @ me as a reviewer!
https://github.com/ros2/ros2_documentation/issues?q=is%3Aopen+is%3Aissue+label%3A%22help+wanted%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants