Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IKL] Merge openni_{camera, launch} into a single repo. #16710

Merged
merged 3 commits into from
Jan 10, 2018

Conversation

130s
Copy link
Member

@130s 130s commented Jan 6, 2018

Following the decision in ros-drivers/openni_launch#30

@130s
Copy link
Member Author

130s commented Jan 6, 2018

Not sure why CI failed.

https://travis-ci.org/ros/rosdistro/builds/325866852#L9066

rosdistro: DEBUG: Skipped "git_manifest_provider()": Unable to fetch package.xml: Could not clone repository "https://github.com/ros-gbp/openni_camera-release.git" at reference "release/kinetic/openni_launch/1.9.5-0"

Indeed this tag doesn't exist in the release repo yet, as the package has never been released from the new release repo yet. I think I'll run bloom to push artifact to the release repo without making PR to rosdistro.

@130s
Copy link
Member Author

130s commented Jan 6, 2018

CI passed. Please squash if needed.

As ros-drivers/openni_camera#56 (comment), test might always fail on GitHub for UNSTABLE, which makes the maintenance harder.
@mikaelarguedas
Copy link
Member

holding for upcoming lunar sync. Once it's done I'll leave it to @tfoote to merge when appropriate

@tfoote tfoote merged commit a8b5527 into ros:master Jan 10, 2018
@130s 130s deleted the ikl/merge_openni_launch branch January 10, 2018 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants