Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move joint_state_publisher from robot_model to it's own repository (indigo/kinetic/lunar) #15926

Merged
merged 5 commits into from
Sep 15, 2017
Merged

Move joint_state_publisher from robot_model to it's own repository (indigo/kinetic/lunar) #15926

merged 5 commits into from
Sep 15, 2017

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Sep 15, 2017

part of ros/robot_model#195

To indigo this releases 1.11.15-0
To kinetic/lunar this releases 1.12.12-0

This moves joint_state_publisher out of the robot_model repository. Bloom was used up to the point of creating this pull request.

$ bloom-release --version
0.5.26

@mikaelarguedas
Copy link
Member

Looks good to me.
Before removing the package from the robot_model source repo, it may be worth checking downstream packages to make sure nobody relies on the previous URI like it happened when we started moving robot model packages

@sloretz
Copy link
Contributor Author

sloretz commented Sep 15, 2017

@mikaelarguedas good idea. Looks like this is in the clear. I checked two levels down using the ros wiki Used by. All were on github so I searched for joint_state_publisher and robot_model. Nothing looking like a URL came up.

@sloretz sloretz changed the title Move joint_state_publisher from robot_model to it's own repository (indigo) Move joint_state_publisher from robot_model to it's own repository (indigo/kinetic) Sep 15, 2017
@sloretz sloretz changed the title Move joint_state_publisher from robot_model to it's own repository (indigo/kinetic) [WIP] Move joint_state_publisher from robot_model to it's own repository (indigo/kinetic) Sep 15, 2017
@sloretz sloretz changed the title [WIP] Move joint_state_publisher from robot_model to it's own repository (indigo/kinetic) [WIP] Move joint_state_publisher from robot_model to it's own repository (indigo/kinetic/lunar) Sep 15, 2017
@sloretz sloretz changed the title [WIP] Move joint_state_publisher from robot_model to it's own repository (indigo/kinetic/lunar) Move joint_state_publisher from robot_model to it's own repository (indigo/kinetic/lunar) Sep 15, 2017
@dirk-thomas
Copy link
Member

While Jade has just been EOLed you might want to make an effort to maintain the ability to build it from source in case users still want to do so.

@mikaelarguedas
Copy link
Member

@sloretz @clalancette I just noticed something fishy with EOL distros:
All distros before indigo are fine because they had their own branchs that stayed unmodified and still have all the packages in them.
Now that Jade became EOL it's a bit trickier because it uses the indigo-devel branch like indigo but that branch doesn't have the packages anymore so people cannot build them from source anymore.
Speaking with @tfoote the best way to go would be to create a tag jade-devel on the robot-model repo with the state of the repo before Jade became EOL and update the Jade disctibution file to point to that new tag rather than the indigo-devel branch

@sloretz
Copy link
Contributor Author

sloretz commented Sep 15, 2017

@mikaelarguedas PR #15927 updates the jade distribution.yaml to use the tag jade-devel. May I ask you to check if I missed anything in it?

@sloretz sloretz merged commit d8b2340 into ros:master Sep 15, 2017
@sloretz sloretz deleted the move_joint_state_publisher branch September 15, 2017 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants