[ROS-O] required patches on current systems #2297
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This one likely needs another pass with test failures. |
|
I've updated the roslogging patch. This version works for me with Ubuntu 20.04 (ROS Noetic) as well as Debian testing (Python 3.11) |
jspricke
force-pushed
the
obese-devel
branch
from
5022a21 to
75b4aaf
Compare
|
We were having runtime issues with Python 3.11 in our NixOS 23.11 build. I've patched this change on and it seems to be working better. Will report back any new problems we find. |
jspricke
changed the title
The file descriptor hard limit was bumped resulting in each ROS node allocating 8GB: https://lists.debian.org/debian-devel/2024/06/msg00041.html
With fixes by Jochen Sprickerhof. Taken from https://salsa.debian.org/science-team/ros-ros-comm/-/blob/b74ca5c2c868a084ab36e46d68f7775518ac4c58/debian/patches/0016-Fixes-for-Python-3.12.patch
this is implicitly pulled-in through the test depends on rosunit, but fails with ros-infrastructure/bloom#649 which disables test dependencies.
We just need to protect against symbols starting with double underscores. Having double underscores anywhere else isn't a problem.
Return value should not change constness of this pointer!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.