Skip to content
This repository has been archived by the owner on Aug 3, 2020. It is now read-only.

Sensor parsing #125

Closed
wants to merge 6 commits into from
Closed

Sensor parsing #125

wants to merge 6 commits into from

Conversation

rhaschke
Copy link
Contributor

Allow for generic parsing of sensors.
This PR provides some convenience methods to parse sensor elements in URDF using plugin libs found by the pluginlib mechanism. This builds on top of ros/urdfdom#84 and ros/urdfdom_headers#22.
Example usage can be seen in the unittest of tactile_toolbox.

@rhaschke
Copy link
Contributor Author

@jacquelinekay Do you think this set of PRs (ros/urdfdom_headers#22, ros/urdfdom#84, and this one) to allow basic, plugin-based parsing of <sensor> tags has a chance to be integrated into kinetic?

I know, you are thinking about urdf2, but I guess this will take a little bit longer ;-)

The code is ABI-compatible to the previous libs (building on urdfdom 0.4) and we used it successfully for some weeks now. Actually, the code primarily touches the sensor parsing only, which wasn't productive before at all.

@rhaschke
Copy link
Contributor Author

Friendly ping.
I know the checks are failing. This is due to changes required also in urdfdom and urdfdom_headers.
It would be really cool to get the modularized sensor parsing (using pluginlib) in at some point ;-)

@rhaschke rhaschke changed the base branch from indigo-devel to kinetic-devel September 13, 2016 20:58
@clalancette
Copy link
Contributor

@rhaschke I know it has been a long time on this one, and for that I'm sorry. Are you still interested in getting this in? If so, can you please give us a better description of what exactly you are trying to achieve with this PR? Also, I believe the build should be able to complete now. Finally, I think we'd want to have some additional unit tests to cover this functionality, so to go forward with this we'd also want that. Thank you for your patience.

@rhaschke
Copy link
Contributor Author

@clalancette I'm still very interested to get the sensor description parsing more modularized. The idea is to extend sensor support beyond Camera and Ray, but to allow any custom sensor description with appropriate parsers provided via plugins. We use that mechanism for example to describe tactile sensors for our tactile toolbox. For a detailed motivation, please have a look at ros/urdfdom#84.
This PR is only the very last in a whole series of PRs also involving ros/urdfdom_headers#22 and ros/urdfdom#84. Hence, it cannot compile without those. And yes, there are unittests provided in urdfdom already.

@sloretz
Copy link
Contributor

sloretz commented Dec 18, 2017

@rhaschke Thanks for the pull request! The urdf packages have been moved to their own repo as part of #195. Would you mind moving this to https://github.com/ros/urdf?

@sloretz sloretz closed this Dec 18, 2017
@rhaschke rhaschke mentioned this pull request Dec 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants