-
Notifications
You must be signed in to change notification settings - Fork 104
Conversation
@jacquelinekay Do you think this set of PRs (ros/urdfdom_headers#22, ros/urdfdom#84, and this one) to allow basic, plugin-based parsing of I know, you are thinking about urdf2, but I guess this will take a little bit longer ;-) The code is ABI-compatible to the previous libs (building on urdfdom 0.4) and we used it successfully for some weeks now. Actually, the code primarily touches the sensor parsing only, which wasn't productive before at all. |
Friendly ping. |
- crashes on exit: ros/class_loader#33 - on-demand-unloading works with ros/class_loader#34
0db3924
to
0636346
Compare
@rhaschke I know it has been a long time on this one, and for that I'm sorry. Are you still interested in getting this in? If so, can you please give us a better description of what exactly you are trying to achieve with this PR? Also, I believe the build should be able to complete now. Finally, I think we'd want to have some additional unit tests to cover this functionality, so to go forward with this we'd also want that. Thank you for your patience. |
@clalancette I'm still very interested to get the sensor description parsing more modularized. The idea is to extend sensor support beyond Camera and Ray, but to allow any custom sensor description with appropriate parsers provided via plugins. We use that mechanism for example to describe tactile sensors for our tactile toolbox. For a detailed motivation, please have a look at ros/urdfdom#84. |
@rhaschke Thanks for the pull request! The urdf packages have been moved to their own repo as part of #195. Would you mind moving this to https://github.com/ros/urdf? |
Allow for generic parsing of sensors.
This PR provides some convenience methods to parse sensor elements in URDF using plugin libs found by the pluginlib mechanism. This builds on top of ros/urdfdom#84 and ros/urdfdom_headers#22.
Example usage can be seen in the unittest of tactile_toolbox.