Make exported target use CMAKE_INSTALL_INCLUDEDIR #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shane Loretz <[email protected]>
clalancette
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
This looks good to me. @scpeters could you take a look at this, and if you approve, merge and do a new tag for this package?
scpeters
approved these changes
Mar 8, 2022
sloretz
deleted the
sloretz__console_bridge__target_use_cmake_install_includedir
branch
https://github.com/ros/console_bridge/releases/tag/1.0.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the exported target had hard coded
includeinstead of${CMAKE_INSTALL_INCLUDEDIR}. This bug would only be an issue if a user manually specified a different include directory on the command line tocmake.