Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for macros with multiple arguments #69

Merged
merged 1 commit into from
May 6, 2020
Merged

Add test for macros with multiple arguments #69

merged 1 commit into from
May 6, 2020

Conversation

scpeters
Copy link
Contributor

@scpeters scpeters commented May 6, 2020

I wrote the following test while reviewing #64 but added it to a separate pull request to keep things simple.

On my machine it prints:

[ RUN      ] ConsoleTest.MultipleArguments
Error:   no extra parameters
         at line 32 in /Users/scpeters/clone/console_bridge/test/console_TEST.cc
Error:   one integer: 42
         at line 33 in /Users/scpeters/clone/console_bridge/test/console_TEST.cc
Error:   two floats: 42.010000, 0.33
         at line 34 in /Users/scpeters/clone/console_bridge/test/console_TEST.cc
[       OK ] ConsoleTest.MultipleArguments (0 ms)

@scpeters scpeters requested a review from clalancette May 6, 2020 21:26
@scpeters scpeters merged commit bf4346b into ros:master May 6, 2020
@scpeters scpeters deleted the multiple_arguments_test branch May 6, 2020 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@scpeters @clalancette