Make CMake configuration files relocatable #45
Conversation
See discussion in ros#44
traversaro
force-pushed
the
relocatable-cmake
branch
from
b963db0 to
f78a1ca
Compare
|
👍 Tested this PR with ros2 and it solves the problem of not being able to find console_bridge. (The original problem being the console_bridge-config.cmake file keeps an absolute path of the building machine for include and library folders. So it cannot be deployed to another location or another machine with a different folder structure) |
|
@mikaelarguedas will this PR be necessary for console_bridge in beta2? It seems like it should be. |
|
@nuclearsandwich Sorry I forgot to reply to that after we discussed it offline. Yes this needs to be in if we want users to be able to build packages on top of our binaries / archives. The only scenario it would work without this change is for linux users using debian packages. @j-rivero @scpeters any chance to get this reviewed and merged in the near future? |
Review would certainly be welcome and I'd love to get back to tracking master for future releases, but this would not block beta2 if it waited since the packaged build is based my branch here: #46 which incorporates this branch as well as some others. |
It's only the deb packaging jobs right? not the packaging jobs for the other platforms? I agree we could track that in the meantime |
I set up a ros2 fork of console_bridge containing only ros/console_bridge#45 instead of my additional changes.
* use fork of console bridge with relocatable cmake files * Use a fork containing relocatable cmake only. I set up a ros2 fork of console_bridge containing only ros/console_bridge#45 instead of my additional changes.
|
sorry for the delay in reviewing, this looks great! |
…cker#373) * use fork of console bridge with relocatable cmake files * Use a fork containing relocatable cmake only. I set up a ros2 fork of console_bridge containing only ros/console_bridge#45 instead of my additional changes.
See discussion in #44 .