Implement the use of the generate_export_header cmake macro #43
Conversation
|
I've been peeking at the cmake source code, and I think this requires cmake 2.8.6 since it exists here: but not in 2.8.5: Should we upgrade the cmake version requirement in CMakeLists.txt? |
done in c322c60 |
|
Is there anything pending? The changes look good to me and would help ros2/rmw_fastrtps#87 a lot. Thanks. |
|
Thanks for the ping @esteve; it looks good to me too. Is it enough for ros2 to have this in the master branch, or do we need another release? |
|
master branch is fine 👍 , thanks ! |
|
For now we can use the |
|
Well, we can ask @j-rivero if he thinks a 0.3.3 could make it into xenial. Otherwise it could be hosted on our package server or a PPA. |
Given the situation, I think that we hardly can argue that this fix falls under the Stable Release Update category. If the new version only includes this patch or do not touch the ABI it is fine to host it in any of our repositories. If the current |
|
@scpeters thanks for merging the PR, this should pave the way for ros2/rmw_fastrtps#87 to be merged as well. |
|
@j-rivero if I released 0.3.3 today, could it get into Ubuntu zesty? |
A bit late since it is Final Freeze and the policies for Stable Release Updates (SRUs) applied also to this final step. |
* Implement the use of the generate_export_header cmake macro * Changes in build system and header file * Include export file header in the installation * Update cmake version required (cherry picked from commit 9ef664d)
After discussion in #42 following @traversaro suggestion in #40
I've tested it Ubuntu Xenial with GCC 5.4.0 and Windows7 with MSVC 2013.