Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler warning on Windows #32

Closed
dirk-thomas opened this issue Jan 25, 2016 · 5 comments
Closed

compiler warning on Windows #32

dirk-thomas opened this issue Jan 25, 2016 · 5 comments

Comments

@dirk-thomas
Copy link
Member

console_bridge/src/console.cpp

Line 153 in bbcc914

file_ = fopen(filename, "a");

'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.

http://ci.ros2.org/view/packaging/job/packaging_windows/103/warnings34Result/package.-318397937/
@dirk-thomas dirk-thomas mentioned this issue Jan 26, 2016
Closed
@scpeters
Copy link
Contributor

What do you think of scpeters@5c2d920

@dirk-thomas
Copy link
Member Author

The compiler wants something slightly different 😉 http://ci.ros2.org/view/packaging/job/packaging_windows/108/console

@scpeters
Copy link
Contributor

At least it was only two errors (I think). Hopefully scpeters@0e4574d is better

@dirk-thomas
Copy link
Member Author

Thank you, looks good: http://ci.ros2.org/job/packaging_windows/109/warnings34Result/fixed/

scpeters added a commit to scpeters/console_bridge that referenced this issue Jan 26, 2016
@scpeters
Fix windows compiler warning
d231a9d 
Use fopen_s instead of fopen on Windows,
and check the error code.

Closes ros#32.
@scpeters scpeters mentioned this issue Jan 26, 2016
Merged
@scpeters
Copy link
Contributor

Ok, I squashed and submitted as #33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dirk-thomas @scpeters