Add optional namespace to /set_camera_info service in CameraInfoManager #324
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
In the quite common case that one node serves two cameras and where each camera has its own
CameraInfoManager,
there will only be one/set_camera_info
service that will update both .yaml files which is not ideal.Up until Jazzy this could have been remedied by using a sub-node with its custom namespace, however since updating the code to work with lifecycle nodes this is not possible anymore.
I have added a
ns
parameter toCameraInfoManager
constructors that will be added as a prefix to the/set_camera_info
service during its creation. As the parameter is optional, without specyfing itCameraInfoManager
will act as before - the string passed during the creation of the service will be~/set_camera_info
. This ensures backwards compatibility and would not require anybody to modify their code and this would allow bigger control for users over the name of the service.This would be great to backport to Jazzy