Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurations for omitting package testing #903

Merged
merged 5 commits into from
Oct 15, 2021

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Aug 25, 2021

The goal here is to provide a mechanism to disable test invocation in the binary package builds (deb/RPM) but maintain the existing best-effort behavior.

@gavanderhoorn
Copy link
Contributor

Is this work towards a fix for #895?

@cottsay
Copy link
Member Author

cottsay commented Aug 30, 2021

Is this work towards a fix for #895?

No, this would allow us to disable testing in debian and RPM package builds entirely.

@cottsay cottsay marked this pull request as ready for review October 13, 2021 16:29
Copy link
Contributor

@nuclearsandwich nuclearsandwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I raised a couple of questions but nothing that I think is really blocking. The configuration file layout is something we discussed offline and I think it's the best way to evolve how we're handling testing during package builds.

ros_buildfarm/common.py Outdated Show resolved Hide resolved
ros_buildfarm/config/release_build_file.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants