Trajectory Interpolator (Against Kinetic Devel) #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 14, 2017 12:19
jrgnicho
reviewed
May 15, 2017
| @@ -11,6 +11,7 @@ | |||
| <maintainer email="[email protected]">Jonathan Meyer</maintainer> | |||
|
|
|||
| <license>Apache 2.0</license> | |||
| <license>BSD</license> | |||
There was a problem hiding this comment.
The license on the source files still says Apache 2.0
There was a problem hiding this comment.
I lifted some code from the ecl library, which is licensed as BSD. I imagine I should include the BSD clause in that source file? I have no idea how this dual licensing stuff would work.
|
So I resurrected this PR after closing it a while ago after discussing with @Levi-Armstrong. It amused me that this is not too different from what MoveIt was doing and I wanted to keep the code around somewhere. |
| @@ -0,0 +1,232 @@ | |||
| /** | |||
There was a problem hiding this comment.
Is this the code that is BSD? If so, I think it needs to be labeled BSD similar to the others that are marked Apache.
jrgnicho
reviewed
May 16, 2017
| // else | ||
| // { | ||
| // std::cout << "It did not work\n"; | ||
| // } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.