Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clockwise image rotation #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GeorgeK-zn
Copy link

No description provided.

@furushchev
Copy link
Collaborator

Thank you for the contribution!
I think you can get rotated images by any degrees by combining this node and image_rotate node.
Please check the documentation:http://wiki.ros.org/image_rotate

@GeorgeK-zn
Copy link
Author

In my case running another node was not an option, so I thought I might not be alone.
Thank you for the suggestion, I'll definitely use image_rotate in future products.

So are you interested in this feature, should I improve on anything or just close the PR?

@awesomebytes
Copy link
Member

If we were to support this I'd rather be able to rotate the image in all the available rotations from Opencv:

  cv::ROTATE_90_CLOCKWISE = 0,
  cv::ROTATE_180 = 1,
  cv::ROTATE_90_COUNTERCLOCKWISE = 2 

I see its usefulness, though. If you add that, I'd be happy to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants