Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copying the entire openni_launch package from https://github.com/ros-drivers/openni_launch. #57

Merged
merged 3 commits into from
Jan 6, 2018

Conversation

130s
Copy link
Member

@130s 130s commented Jan 4, 2018

See ros-drivers/openni_launch#30 (comment) for the decision for this change.

Preserving commit history was attempted (using the method in this article), but didn't seem to easily work due to ros-drivers/openni_launch#4 that resurrects the change made previously in a few files and somehow git am command stops. So unfortunately, instead of spending more time on trying to save the commit history, I suggest to move forward.

This addresses #53.

130s added 3 commits October 30, 2017 20:33

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
…drivers/openni_launch.

See ros-drivers/openni_launch#30 (comment) for the decision for this change.

Preserving commit history was attempted (using the method in http://www.pixelite.co.nz/article/extracting-file-folder-from-git-repository-with-full-git-history), but didn't seem to easily work due to ros-drivers/openni_launch#4 that resurrects the change made previously in a few files and somehow `git am` command stops. So unfortunately, instead of spending more time on trying to save the commit history, I suggest to move forward.
@130s
Copy link
Member Author

130s commented Jan 5, 2018

ROS pre-release test, which checks downstream packages, failed for Indigo here and Kinetic (at the bottom of the log) for the same following key error in some of the downstream package(s). This looks irrelevant to the change in this PR.

KeyError: "The cache has no package named 'gdown'"

@130s
Copy link
Member Author

130s commented Jan 6, 2018

Buildfarm test failed for the same reason as #56 (comment), which we ignored then. So do I this time as well.

@130s 130s merged commit 7e39c15 into ros-drivers:indigo-devel Jan 6, 2018
@130s 130s deleted the i/add_openni_launch branch January 6, 2018 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant