Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Big Merge #29

Merged
merged 46 commits into from
Feb 17, 2021
Merged

The Big Merge #29

merged 46 commits into from
Feb 17, 2021

Conversation

mikemahoney218
Copy link
Member

This PR address reviewer comments from the first review of {terrainr} (see ropensci/software-review#416 (comment) ).

@codecov
Copy link

codecov bot commented Feb 17, 2021

Codecov Report

Merging #29 (3645fc8) into main (91a73a4) will increase coverage by 1.35%.
The diff coverage is 94.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   95.88%   97.24%   +1.35%     
==========================================
  Files          14       12       -2     
  Lines         704      761      +57     
==========================================
+ Hits          675      740      +65     
+ Misses         29       21       -8     
Impacted Files Coverage Δ
R/combine_overlays.R 95.45% <ø> (ø)
R/georeference_overlay.R 95.00% <ø> (-5.00%) ⬇️
R/get_tiles.R 95.73% <89.28%> (-4.27%) ⬇️
R/geom_spatial_rgb.R 92.00% <92.00%> (ø)
R/calc_haversine_distance.R 95.65% <94.73%> (-4.35%) ⬇️
R/add_bbox_buffer.R 98.50% <98.48%> (-1.50%) ⬇️
R/classes.R 100.00% <100.00%> (ø)
R/hit_api.R 100.00% <100.00%> (+13.41%) ⬆️
R/merge_rasters.R 100.00% <100.00%> (+15.62%) ⬆️
R/raster_to_raw_tiles.R 100.00% <100.00%> (ø)
... and 4 more

@mikemahoney218
Copy link
Member Author

deep breath

@mikemahoney218 mikemahoney218 merged commit 753a265 into main Feb 17, 2021
@mikemahoney218 mikemahoney218 deleted the reviewer_comments branch February 17, 2021 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants