Avoid partial matches

ropensci · Nov 21, 2024 · ab30e7b · ab30e7b
1 parent 938156c
commit ab30e7b
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 7 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -12,7 +12,7 @@ Description: Pipeline tools coordinate the pieces of computationally
   The methodology in this package
   borrows from GNU 'Make' (2015, ISBN:978-9881443519)
   and 'drake' (2018, <doi:10.21105/joss.00550>).
-Version: 1.9.0.9001
+Version: 1.9.0.9002
 License: MIT + file LICENSE
 URL: https://docs.ropensci.org/targets/, https://github.com/ropensci/targets
 BugReports: https://github.com/ropensci/targets/issues

diff --git a/NEWS.md b/NEWS.md
@@ -1,8 +1,9 @@
-# targets 1.9.0.9001 (development)
+# targets 1.9.0.9002 (development)
 
 ## Bug fixes
 
 * Allow branch references to contain multi-element `path` vectors with cloud metadata (#1382, @n8layman).
+* Avoid partial matches in internal code (#1384, @olivroy).
 
 # targets 1.9.0
 

diff --git a/R/class_database.R b/R/class_database.R
@@ -110,7 +110,7 @@ database_class <- R6::R6Class(
     set_row = function(row) {
       lookup_set(
         .subset2(self, "lookup"),
-        name = as.character(.subset2(row, "name")),
+        names = as.character(.subset2(row, "name")),
         object = as.list(row)
       )
     },

diff --git a/R/class_future.R b/R/class_future.R
@@ -134,7 +134,7 @@ future_class <- R6::R6Class(
       future <- do.call(what = future::future, args = args)
       lookup_set(
         lookup = self$worker_list,
-        name = target_get_name(target),
+        names = target_get_name(target),
         object = future
       )
     },

diff --git a/R/class_summary.R b/R/class_summary.R
@@ -16,7 +16,7 @@ summary_class <- R6::R6Class(
       }
     },
     report_start = function() {
-      cli_df_header(progress_init(path = tempfile())$cli_data())
+      cli_df_header(progress_init(path_store = tempfile())$cli_data())
     },
     report_progress = function(progress, force = FALSE) {
       self$buffer <- cli_df_body(progress$cli_data(), print = FALSE)

diff --git a/R/tar_config_set.R b/R/tar_config_set.R
@@ -213,7 +213,7 @@ tar_config_set <- function(
   yaml[[project]]$as_job <- as_job %|||% yaml[[project]]$as_job
   yaml[[project]]$garbage_collection <- garbage_collection %|||%
     yaml[[project]]$garbage_collection
-  yaml[[project]]$label <- label %|||% yaml[[project]]$label
+  yaml[[project]][["label"]] <- label %|||% yaml[[project]][["label"]]
   yaml[[project]]$label_width <- label_width %|||% yaml[[project]]$label_width
   yaml[[project]]$level_separation <- level_separation %|||%
     yaml[[project]]$level_separation

diff --git a/tests/testthat/test-class_builder.R b/tests/testthat/test-class_builder.R
@@ -207,7 +207,6 @@ tar_test("builder writing from worker", {
 })
 
 tar_test("retrieval = \"none\"", {
-  skip_cran()
   skip_cran()
   tar_script({
     list(