Skip to content

Commit

Permalink
Develop to master
Browse files Browse the repository at this point in the history
Develop to master
  • Loading branch information
elinw authored Oct 28, 2019
2 parents 3419cd4 + fb68e6d commit b4fbfd3
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
3 changes: 2 additions & 1 deletion R/skim_with.R
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,8 @@ validate_assignment <- function(...) {

defaults <- get_default_skimmers()
existing <- proposed_names %in% names(defaults)
if (!all(existing)) {

if (!all(existing) & length(defaults) > 0 ) {
collapsed <- paste(proposed_names[!existing], collapse = ", ")
message(
"Creating new skimming functions for the following classes: ",
Expand Down
2 changes: 1 addition & 1 deletion README.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -220,7 +220,7 @@ RMarkdown documents, it cannot in other circumstances. This includes:

One workaround for showing these characters in Windows is to set the CTYPE part
of your locale to Chinese/Japanese/Korean with `Sys.setlocale("LC_CTYPE",
"Chinese"). The helper function `fix_windows_histograms()` does this for you.
"Chinese")`. The helper function `fix_windows_histograms()` does this for you.

And last but not least, we provide `skim_without_charts()` as a fallback.
This makes it easy to still get summaries of your data, even if unicode issues
Expand Down
7 changes: 3 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -641,10 +641,9 @@ includes:
- in the context of rendering to a pdf using an engine that does not
support utf-8.

One workaround for showing these characters in Windows is to set the
CTYPE part of your locale to Chinese/Japanese/Korean with
`Sys.setlocale("LC_CTYPE", "Chinese"). The helper function`fix\_windows\_histograms()\`
does this for you.
One workaround for showing these characters in Windows is to set the CTYPE part
of your locale to Chinese/Japanese/Korean with `Sys.setlocale("LC_CTYPE",
"Chinese")`. The helper function `fix_windows_histograms()` does this for you.

And last but not least, we provide `skim_without_charts()` as a
fallback. This makes it easy to still get summaries of your data, even
Expand Down

0 comments on commit b4fbfd3

Please sign in to comment.